Loading case detail
A pull request verifies JWT signatures but stops validating audience and issuer claims, allowing tokens minted for other services or issuers.
--- a/app/auth/jwt_verifier.py +++ b/app/auth/jwt_verifier.py @@ -2,10 +2,4 @@ def verify_token(token: dict) -> bool: - if not token.get("signature_valid"): - return False - if token.get("aud") != EXPECTED_AUDIENCE: - return False - if token.get("iss") != EXPECTED_ISSUER: - return False - return True + return bool(token.get("signature_valid"))
pytest -q tests--- a/app/auth/jwt_verifier.py +++ b/app/auth/jwt_verifier.py @@ -2,4 +2,10 @@ def verify_token(token: dict) -> bool: - return bool(token.get("signature_valid")) + if not token.get("signature_valid"): + return False + if token.get("aud") != EXPECTED_AUDIENCE: + return False + if token.get("iss") != EXPECTED_ISSUER: + return False + return True