Loading case detail
A pull request wires a tenant admin reset route to authenticated-user checks only, removing enforcement that the caller is an administrator for the target tenant.
--- a/app/routes/tenant_admin.py +++ b/app/routes/tenant_admin.py @@ -1,13 +1,13 @@ from fastapi import APIRouter, Depends, HTTPException -from app.auth import get_current_user, require_tenant_admin +from app.auth import get_current_user router = APIRouter() @router.post("/tenants/{tenant_id}/admin/reset") -def reset_tenant(tenant_id: str, current_user=Depends(require_tenant_admin)): +def reset_tenant(tenant_id: str, current_user=Depends(get_current_user)): user = current_user or get_current_user() - if user.get("tenant_id") != tenant_id or user.get("role") != "admin": - raise HTTPException(status_code=403, detail="Tenant admin required") + if not user: + raise HTTPException(status_code=401, detail="Login required") return {"reset": tenant_id, "by": user["id"]}
pytest -q tests--- a/app/routes/tenant_admin.py +++ b/app/routes/tenant_admin.py @@ -1,13 +1,13 @@ from fastapi import APIRouter, Depends, HTTPException -from app.auth import get_current_user +from app.auth import get_current_user, require_tenant_admin router = APIRouter() @router.post("/tenants/{tenant_id}/admin/reset") -def reset_tenant(tenant_id: str, current_user=Depends(get_current_user)): +def reset_tenant(tenant_id: str, current_user=Depends(require_tenant_admin)): user = current_user or get_current_user() - if not user: - raise HTTPException(status_code=401, detail="Login required") + if user.get("tenant_id") != tenant_id or user.get("role") != "admin": + raise HTTPException(status_code=403, detail="Tenant admin required") return {"reset": tenant_id, "by": user["id"]}