Loading case detail
A pull request returns model citations directly without checking that citation IDs exist in the retrieved source chunks.
--- a/rag/answer.py +++ b/rag/answer.py @@ -1,6 +1,2 @@ def build_answer(generator, retrieved_chunks): - answer = generator(retrieved_chunks) - valid_ids = {chunk["id"] for chunk in retrieved_chunks} - if any(citation not in valid_ids for citation in answer["citation_ids"]): - raise ValueError("Answer contained an unsupported citation") - return answer + return generator(retrieved_chunks)
pytest -q tests--- a/rag/answer.py +++ b/rag/answer.py @@ -1,2 +1,6 @@ def build_answer(generator, retrieved_chunks): - return generator(retrieved_chunks) + answer = generator(retrieved_chunks) + valid_ids = {chunk["id"] for chunk in retrieved_chunks} + if any(citation not in valid_ids for citation in answer["citation_ids"]): + raise ValueError("Answer contained an unsupported citation") + return answer