Loading case detail
A pull request removes the processed-event guard so duplicate Kafka deliveries can credit the same payment twice.
--- a/consumer/payments.py +++ b/consumer/payments.py @@ -1,10 +1,6 @@ class PaymentConsumer: def __init__(self, ledger): self.ledger = ledger - self.processed_event_ids = set() def handle(self, event): - if event["event_id"] in self.processed_event_ids: - return self.ledger.credit(event["account_id"], event["amount"]) - self.processed_event_ids.add(event["event_id"])
pytest -q tests--- a/consumer/payments.py +++ b/consumer/payments.py @@ -1,6 +1,10 @@ class PaymentConsumer: def __init__(self, ledger): self.ledger = ledger + self.processed_event_ids = set() def handle(self, event): + if event["event_id"] in self.processed_event_ids: + return self.ledger.credit(event["account_id"], event["amount"]) + self.processed_event_ids.add(event["event_id"])